Spurious Flush() in display.capture()#548
Open
ggcrunchy wants to merge 1 commit intocoronalabs:masterfrom
Open
Spurious Flush() in display.capture()#548ggcrunchy wants to merge 1 commit intocoronalabs:masterfrom
ggcrunchy wants to merge 1 commit intocoronalabs:masterfrom
Conversation
Shchvova
approved these changes
Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically,
display.capture()and friends seem to be the only cases where the second overload ofScene::Render()is called. From what I can tell these never need theFlush(); I believe it's just a copy-paste artifact.It's a no-op on most platforms.[1] On Windows, though, it calls
SwapBuffers(). You can see this if you try theCaptureToFilecode sample, where you get a black image for a frame; without theFlush()you don't. From my admittedly foggy recollection the other exceptions were similar "end of frame" / vsync logic.[1] - I'd have to review them to see where it isn't. I did the actual analysis almost a year ago, probably while investigating the Discord streaming crashes. I'm trying to distill a big diff into branches / PRs now, and had this on hand due to testing something or other with
display.capture().