Skip to content

Fix: Loading an invalid image causes a crash #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix: Loading an invalid image causes a crash #678

wants to merge 3 commits into from

Conversation

aoyako
Copy link

@aoyako aoyako commented Feb 21, 2024

Platform: Linux
Fix the issue when Solar crashes with a segmentation fault on loading an invalid image file (.png, .jpg, .bmp).

Steps to reproduce:

  1. Create an empty file with the extension .png (empty.png)
  2. Put the following line in the new project's main.lua
    local background = display.newImageRect("empty.png", 600, 600)

Expected behavior:

Runtime Error is reported.

Actual behavior:

Solar crashed, leaving a log

libpng error: Read Error
Segmentation fault

@aoyako aoyako requested a review from Shchvova as a code owner February 21, 2024 08:09
@CLAassistant
Copy link

CLAassistant commented Feb 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shchvova Shchvova Awaiting requested review from Shchvova Shchvova is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aoyako @CLAassistant