Skip to content

Conversation

jrjsmrtn
Copy link

@jrjsmrtn jrjsmrtn commented Dec 7, 2020

I refactored MountEFI for packaging using setupmeta.

It can be installed using:

$ git clone https://github.com/jrjsmrtn/MountEFI
$ cd MountEFI
$ pip install .

Or, if uploaded to PyPI:

$ pip install --user MountEFI

I added two console_scripts entry points so it can be invoked as:

$ MountEFI

or:

$ mount-efi

The MountEFI.command is still in the repo, so it can copied from a git clone and double-clicked.


I added two features:

  1. a --settings option to specify the settings.json location;

  2. if not specified, the settings file will use the XDG convention by default:

    /Users/${USER}/Library/Application Support/MountEFI/settings.json

    To do that, I added a dependency to the appdirs package.

I removed one feature:

  • if MountEFI is published through PyPI, there is no more need for a self update feature.

I kept individual commits in the PR so you can more easily examine my changes. If this PR is ok for you, I will rebase as one commit.

fix membership and identity tests
fix builtins.input import
move version to __about__ module
fix get_bootloader_uuid import
move MountEFI.command content to __main__ module
expand setupmeta config
add XDG-compliant DEFAULT_SETTINGS_PATH
add --settings CLI option
add appdirs to dependencies
@jrjsmrtn
Copy link
Author

jrjsmrtn commented Dec 7, 2020

Two files are still missing for packaging:

  • LICENCE.txt

    I have no idea what is your licence :-)

  • classifiers.txt.

    I found some Windows support in the code and I am not sure which Python versions you want to support, so I have not yet added classifiers.

    Do you still want to support Python 2.7 ?

It would also be useful to tag versions before/if it's released on PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant