Packaging MountEFI #7
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored
MountEFI
for packaging usingsetupmeta
.It can be installed using:
Or, if uploaded to PyPI:
I added two
console_scripts
entry points so it can be invoked as:or:
The
MountEFI.command
is still in the repo, so it can copied from agit clone
and double-clicked.I added two features:
a
--settings
option to specify thesettings.json
location;if not specified, the settings file will use the XDG convention by default:
/Users/${USER}/Library/Application Support/MountEFI/settings.json
To do that, I added a dependency to the
appdirs
package.I removed one feature:
MountEFI
is published through PyPI, there is no more need for a self update feature.I kept individual commits in the PR so you can more easily examine my changes. If this PR is ok for you, I will rebase as one commit.