Skip to content

Commit 22ce061

Browse files
committed
Fix error during creation of exe by setting stdin to subprocess.DEVNULL
1 parent 929fa2b commit 22ce061

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

Python/stylua.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ def run(input_folder_path, output_folder_path):
2323
elif os.name == "posix": # If the OS is Linux
2424
stylua_path = utils.path("Lib/stylua/Linux/stylua")
2525

26-
result = subprocess.run([stylua_path, output_path], capture_output=True, text=True)
26+
# Setting stdin to subprocess.DEVNULL is necessary for the EXE not to throw "OSError: [WinError 6] The handle is invalid"
27+
result = subprocess.run([stylua_path, output_path], capture_output=True, text=True, stdin=subprocess.DEVNULL)
2728

2829
if result.stderr:
2930
raise WronglyFormattedLuaFile(result.stderr)

main.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
# Run manually: python main.py
2-
# Build EXE: pyinstaller --noconsole --onefile --icon="Media/legacy-mod-converter.ico" --add-data="Media/github-icon.png;Media" --add-data="Media/discord-icon.png;Media" --add-data="Media/finish.wav;Media" --name="Legacy Mod Converter" main.py
32

3+
# This is giving the error `pyinstaller: error: argument --add-binary: invalid add_data_or_binary value: 'Lib/stylua/Linux/stylua:Lib/stylua/Linux'`
4+
# Build EXE: pyinstaller --noconsole --onefile --icon="Media/legacy-mod-converter.ico" --add-data="Media/github-icon.png;Media" --add-data="Media/discord-icon.png;Media" --add-data="Media/finish.wav;Media" --add-binary="Lib/stylua/Linux/stylua:Lib/stylua/Linux" --add-data="Lib/stylua/Windows/stylua.exe;Lib/stylua/Windows" --name="Legacy Mod Converter" main.py
5+
6+
# Build EXE: pyinstaller --noconsole --onefile --icon="Media/legacy-mod-converter.ico" --add-data="Media/github-icon.png;Media" --add-data="Media/discord-icon.png;Media" --add-data="Media/finish.wav;Media" --add-binary="Lib/stylua/Windows/stylua.exe;Lib/stylua/Windows" --name="Legacy Mod Converter" main.py
47

58
import traceback
69
import PySimpleGUI as sg

0 commit comments

Comments
 (0)