Fix UpsertGroup roles #81
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ludydoo thanks for your contribution! This looks good to me. We're currently using Gerrit for reviews so, unfortunately, you'll need to sign our CLA there. There's a bit of information on how to do that at https://github.com/couchbase/couchbase-jvm-clients/blob/master/CONTRIBUTING.md#pull-requests (note: the bot that it mentions no longer exists). If you can sign the CLA then I'll pull the change over to gerrit and get it merged. |
|
Hi @ludydoo were you able to take a look at signing our CLA? We can't see that you have. |
|
Hey @chvck , yes I signed the CLA just now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #80