fixes based on copilot comments

- add request validation
- fix docstrings

Author: RIT3shSapata

db/crud.go

@@ -237,7 +237,8 @@ func (ch ChannelHistoryResp) AddChannelHistoryEntry(name string, seq uint64) {
 // from channel name to the sequences at which the document was removed from that channel.
 // It collects revocation sequences from the active Channels map, the ChannelSet, and the
 // ChannelSetHistory (overflow). Only channels that have been revoked at least once appear in
-// the result; channels the document is currently assigned to are excluded.
+// the result; active memberships with no revocation history are omitted, even though a currently
+// assigned channel can still appear if it was revoked and later re-added.
 func (c *DatabaseCollection) GetDocChannelHistory(ctx context.Context, docid string) (map[string][]uint64, error) {
 
 	chanHistory := make(ChannelHistoryResp)

rest/api_test.go

@@ -4141,6 +4141,28 @@ func TestDocumentChannelHistoryCompact(t *testing.T) {
 
 		assert.Equal(t, expectedOutput, chanOutput)
 	})
+
+	t.Run("empty doc_ids returns 400", func(t *testing.T) {
+		req := CompactDocChannelHistoryRequest{
+			DocIds: []string{},
+			Seq:    1,
+		}
+		bodyBytes, err := base.JSONMarshal(req)
+		require.NoError(t, err)
+		resp := rt.SendAdminRequest("POST", "/{{.keyspace}}/_channel_history/_compact", string(bodyBytes))
+		RequireStatus(t, resp, http.StatusBadRequest)
+	})
+
+	t.Run("seq zero returns 400", func(t *testing.T) {
+		req := CompactDocChannelHistoryRequest{
+			DocIds: []string{"doc1"},
+			Seq:    0,
+		}
+		bodyBytes, err := base.JSONMarshal(req)
+		require.NoError(t, err)
+		resp := rt.SendAdminRequest("POST", "/{{.keyspace}}/_channel_history/_compact", string(bodyBytes))
+		RequireStatus(t, resp, http.StatusBadRequest)
+	})
 }
 
 // TestCompactNonImportedDocWithAutoImport verifies that when CompactDocChannelHistory is called

rest/doc_api.go

@@ -949,7 +949,7 @@ type CompactDocChannelHistoryRequest struct {
 	Seq    uint64   `json:"seq"`
 }
 
-// handleCompactDocChannelHistory handles POST /{keyspace}/_compact_channel_history.
+// handleCompactDocChannelHistory handles POST /{keyspace}/_channel_history/_compact.
 // It accepts a JSON body with a list of doc IDs and a sequence number, and removes channel
 // history entries that ended at or before that sequence for each document, returning the
 // list of compacted channel names per doc ID.
@@ -962,13 +962,23 @@ func (h *handler) handleCompactDocChannelHistory() error {
 		return base.HTTPErrorf(http.StatusBadRequest, "invalid JSON: %v", err)
 	}
 
+	if len(req.DocIds) == 0 {
+		return base.HTTPErrorf(http.StatusBadRequest, "missing doc ids")
+	}
+
+	if req.Seq == 0 {
+		return base.HTTPErrorf(http.StatusBadRequest, "missing seq")
+	}
+
 	res := make(map[string][]string)
 	for _, id := range req.DocIds {
 		channels, err := h.collection.CompactDocChannelHistory(h.ctx(), id, req.Seq)
 		if err != nil && !base.IsDocNotFoundError(err) {
 			return err
 		}
-		res[id] = channels
+		if _, ok := res[id]; !ok {
+			res[id] = channels
+		}
 	}
 
 	h.writeJSON(res)