Move to nightly rust to access async closures #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- A primary design pattern that we want to use is currently challenging due to asybc closures not being supported in stable rust. In order to make this pattern possible we should switch to nightly and enable the feature. async_closures should be moved to stable before we need to release the SDK. Changes -------- Specify the nightly toolchain. Enable async_closures feature. Use async closures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A primary design pattern that we want to use is currently challenging due to asybc closures not being supported in stable rust. In order to make this pattern possible we should switch to nightly and enable the feature. async_closures should be moved to stable before we need to release the SDK.
Changes
Specify the nightly toolchain.
Enable async_closures feature.
Use async closures.