-
Notifications
You must be signed in to change notification settings - Fork 691
[fix][evaluation] ExptInsightAnalysisService add start/end time #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CozeLoop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review Summary: Added validation and API design feedback for start/end time propagation in insight analysis, flagged a must-fix for interface change impacting mocks/tests, and marked safe changes. Please see inline comments for actionable guidance.
47f5f4e to
cb3d068
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #284 +/- ##
=======================================
Coverage ? 68.42%
=======================================
Files ? 569
Lines ? 51661
Branches ? 0
=======================================
Hits ? 35347
Misses ? 13569
Partials ? 2745
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
4e9fbe9 to
0031e40
Compare
0031e40 to
b02c189
Compare
3025458 to
871a25e
Compare
What type of PR is this?
ExptInsightAnalysisService add start/end time for InsightReport analysis
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes: