Skip to content

Add xxHash example #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Add xxHash example #549

merged 3 commits into from
Apr 8, 2024

Conversation

RozeFound
Copy link
Contributor

closes #416

Copy link
Member

@TheLartians TheLartians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for adding the example, this looks like a useful library!
It seems however that it is failing to build on our CI. Could you double-check the code? The error is the following:

  CMake Deprecation Warning at /home/runner/work/CPM.cmake/CPM.cmake/build/xxHash/_deps/xxhash-src/cmake_unofficial/CMakeLists.txt:8 (cmake_minimum_required):
    Compatibility with CMake < 3.5 will be removed from a future version of
    CMake.
  
    Update the VERSION argument <min> value or use a ...<max> suffix to tell
    CMake that the project does not need compatibility with older versions.
  
  
  CMake Error at CMakeLists.txt:22 (target_link_libraries):
    Target "CPMxxHashExample" links to:
  
      xxHash::xxHash
  
    but the target was not found.  Possible reasons include:
  
      * There is a typo in the target name.
      * A find_package call is missing for an IMPORTED target.
      * An ALIAS target is missing.
  
  
  
  CMake Generate step failed.  Build files cannot be regenerated correctly.

Also be sure to run cmake-format. For more info, check out our style guides.

@RozeFound
Copy link
Contributor Author

RozeFound commented Apr 8, 2024

I fixed link error, but unfortunately I can't get cmake-format to work for some reason.
Do I also need to fix the warning? It's fixed in one of a post-release commits, so we can simply use this instead of a release tag.

@TheLartians
Copy link
Member

I fixed link error, but unfortunately I can't get cmake-format to work for some reason.

Ok, no worries, I've run the code formatters on my machine.

Do I also need to fix the warning? It's fixed in one of a post-release commits, so we can simply use this instead of a release tag.

I like using release tags here, so for now let's live with the warning and update once there is another release.

Copy link
Member

@TheLartians TheLartians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the example!

@TheLartians TheLartians enabled auto-merge (squash) April 8, 2024 16:10
@TheLartians TheLartians merged commit c0855c9 into cpm-cmake:master Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example for xxhash
2 participants