Skip to content

do not generate module files with DOWNLOAD_ONLY #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

do not generate module files with DOWNLOAD_ONLY #654

merged 1 commit into from
Mar 12, 2025

Conversation

Avus-c
Copy link
Contributor

@Avus-c Avus-c commented Mar 8, 2025 •
edited
Loading

Resolves #649

Prevents calling cpm_create_module_file when DOWNLOAD_ONLY was set to true.
I see no reason to generate module files, when you're just downloading a dependency.

@higaski higaski mentioned this pull request Mar 10, 2025
Closed
TheLartians
TheLartians approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@TheLartians TheLartians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I see how this can be confusing behaviour.

Perhaps might make sense to add a comment in another PR so future editors understand the reason the exception.

@TheLartians TheLartians merged commit 97023e8 into cpm-cmake:master Mar 12, 2025
11 checks passed
@TheLartians
Copy link
Member

Fix published in v0.40.8 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheLartians TheLartians TheLartians approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to use find_package with a user provided Find* module?
2 participants
@Avus-c @TheLartians