Skip to content

fix: Patch commands fail trying to re-apply the same patch twice#664

Open
BohdanBuinich wants to merge 1 commit intocpm-cmake:masterfrom
BohdanBuinich:feat/fix_patch_command
Open

fix: Patch commands fail trying to re-apply the same patch twice#664
BohdanBuinich wants to merge 1 commit intocpm-cmake:masterfrom
BohdanBuinich:feat/fix_patch_command

Conversation

@BohdanBuinich
Copy link
Copy Markdown

Fixes #618

@BohdanBuinich
Copy link
Copy Markdown
Author

@TheLartians, Could you please review this change and let me know if you agree with it?

@aaeberharter
Copy link
Copy Markdown

I pulled CPM.cmake from the PR and it works for me.
cmake version 3.31.6-msvc6 (bundled with Visual Studio 2022)

Thank you

@aaeberharter
Copy link
Copy Markdown

PATCH_OPTIONS are mentioned in README.md but are not used in CPM.cmake. After this PR is merged we should discuss how to add meaningful patch options.

@BohdanBuinich BohdanBuinich force-pushed the feat/fix_patch_command branch from 5060d97 to 3c3ebf1 Compare June 16, 2025 09:10
@edunad
Copy link
Copy Markdown

edunad commented Jun 19, 2025

Any updates? I'm using the temp fix of SET after the first time cmake runs, but that doesn't work 100% of the time, would be awesome to get this merged soon 💖

@BohdanBuinich
Copy link
Copy Markdown
Author

@TheLartians, what do you think about this fix? Or do you think it’s too messy and have a better idea for handling it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Patch commands fail trying to re-apply the same patch twice

3 participants