-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add paths to codspeed.yml #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
=======================================
Coverage 95.12% 95.12%
=======================================
Files 3 3
Lines 82 82
=======================================
Hits 78 78
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WalkthroughThe CodSpeed GitHub Actions workflow configuration was updated to restrict its triggers. Now, the workflow only runs on pushes and pull requests affecting specific files or directories and only on the "main" branch. No changes were made to exported or public entities in the codebase. Changes
Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/codspeed.yml (2)
6-11
: Verify that the newpaths
filter covers every file that affects benchmarksOnly changes under
cpp-linter-hooks/**
,tests/**
, the workflow file itself, andpyproject.toml
will now trigger CodSpeed.
If benchmark-relevant code lives elsewhere (e.g. asrc/**
folder or top-level Python modules) a commit may silently skip performance checks.- "pyproject.toml" + # Consider adding the actual source tree or a catch-all for Python files + - "src/**" + - "**/*.py"Double-check the repository layout and expand the list if needed.
13-19
: Branch & path restrictions onpull_request
could miss valid PRsLimiting to
branches: [ "main" ]
is fine—GitHub compares against the base branch—but the same path filter caveat applies here.
External contributors editing files outside the listed paths will not get benchmark feedback, which may hide regressions.Consider whether you want CodSpeed on every PR targeting main, irrespective of touched files, or keep the current optimisation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/codspeed.yml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Run benchmarks
CodSpeed Performance ReportMerging #84 will not alter performanceComparing Summary
|
follow-up to #81
Summary by CodeRabbit