Fix FD leak in POSIX pipe setup and correct write_all_nullptr_case #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pipe setup - freestanding/io_buffer/output.h: fix write_all_nullptr_case to dispatch to scatter_write_all(_bytes)_decay on the output stream (optstm), and keep buffer_curr consistent. - hosted/platforms/posix.h: avoid FD leaks in the POSIX pipe constructor by wrapping FDs with posix_file_factory and setting FD_CLOEXEC; transfer ownership explicitly and keep a single assignment point. No API changes. Success paths unchanged. Rebase-only history preserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues in the file/device I/O path:
scatter_write_all(_bytes)_decay on the output stream and keep buffer pointers
consistent.
(posix_file_factory) and setting FD_CLOEXEC; make ownership transfer explicit
and maintain a single assignment point.
Notes: