-
Notifications
You must be signed in to change notification settings - Fork 683
Move asset bundles into separate package #17930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@brianjhanson looks like this broke some asset bundle tests |
Contributor
Author
|
Found some issues with this. Closing so I can fix those up (and maybe reevaluate this approach) |
Member
|
@brianjhanson I take it you’re happy with this now? Can you merge |
This was referenced Nov 13, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all of our existing asset bundle assets into a
packages/craftcms-asset-bundlesfolder and@craftcms/asset-bundlessubpackage. Much like #17924 this will allow us to split the build process between legacy and modern assets.The number of changes makes GitHub's diff choke, so important things are:
@assetBundlesalias in the yii2-adapter that points topackages/craftcms-asset-bundles$sourcePaths with@assetBundlesalias pathssrcanddistdirectories intopackages/craftcms-asset-bundlesThe build command is now
build:bundlesso you can build all the asset bundles withnpm run build:bundles. Passing arguments gets a little more awkward unfortunately. To build a specific bundle you have to double up your--so the command ends up beingThis update unfortunately breaks the
npm run serve ...commands because that currently relies on the front-end assets being colocated with the asset bundle class in order to resolve the dev server via the /which-asset route. I haven't figured out the best way around that, but it might just be to ignore it. Ideally we won't be doing substantial dev on any of these asset bundles going forward.