[6.x] Fix assets #18083
Merged
[6.x] Fix assets #18083
+18,609
−11,872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@brianjhanson I went ahead and merged this as it solves the most pressing issues |
This was referenced Nov 20, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll call #17930 a failed experiment. Something about having the asset bundles in their own package (and with their own build process) seems to cross a few wires. I'mg uessing it has to do with the mono repo setup, but I wasn't able to track down anything in particular. I just got things to work when I reverted what I did previously.
This moves the asset bundles into the
yii2-adapterpackage. I was originally trying to avoid this because I thought we might be able to use some of the asset bundles for the new CP, but I think that's becoming less likely.I'd still like to come up with some kind of system where we can maintain the old asset bundles and new front-end assets without a huge headache, but I think that's a problem we can solve another day.
Opening as a draft because I still need to work through some CSS variable issues, but I'm hoping this is far enough that @lukeholder and @riasvdv can make sure this is better and not worse.