Skip to content

[5.x] Only update canonical titles of variants #4130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 5.x
Choose a base branch
from
Open

[5.x] Only update canonical titles of variants #4130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d105f02
only update canonical
lukeholder Oct 6, 2025
03b766b
Merge branch '5.x' into luke/com-475-5x-variant-title-is-updated-unin…
lukeholder Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
# Release Notes for Craft Commerce

## Unreleased

- Fixed a bug where variant titles were being incorrectly updated when the Variant Title Format referenced the product. ([#4126](https://github.com/craftcms/commerce/issues/4126))

## 5.4.7.1 - 2025-10-09

- Fixed a PHP error that could occur when querying variants. ([#4129](https://github.com/craftcms/commerce/pull/4129))

## 5.4.7 - 2025-10-08

- Fixed a bug where catalog pricing rules could generate promotional prices for non-promotable purchasables. ([#4118](https://github.com/craftcms/commerce/issues/4118))
- Fixed a bug where variants weren’t getting duplicated correctly. ([#4125](https://github.com/craftcms/commerce/issues/4125))
- Fixed a bug where variants weren't duplicating correctly. ([#4125](https://github.com/craftcms/commerce/issues/4125))
- Fixed a SQL error that could occur when deleting a shipping method.

## 5.4.6 - 2025-09-04
Expand Down
3 changes: 2 additions & 1 deletion src/elements/Product.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1807,7 +1807,8 @@ public function beforeSave(bool $isNew): bool
{
$productType = $this->getType();

if (!$productType->hasVariantTitleField &&
if ($this->getIsCanonical() &&
!$productType->hasVariantTitleField &&
$productType->variantTitleFormat &&
StringHelper::containsAny($productType->variantTitleFormat, ['product.', 'owner.', 'primaryOwner.'])
) {
Expand Down
Loading