Skip to content

Improve import of invisible bar lines in musicxml2hum #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve import of invisible bar lines in musicxml2hum #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da764a2
Report barstyle none as invisible measure style
WolfgangDrescher May 23, 2024
f687701
Merge branch 'master' into musicxml2hum
WolfgangDrescher Oct 11, 2024
6ded32a
Merge branch 'master' into musicxml2hum
WolfgangDrescher Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion min/humlib.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//
// Programmer: Craig Stuart Sapp <craig@ccrma.stanford.edu>
// Creation Date: Sat Aug 8 12:24:49 PDT 2015
// Last Modified: Fr 11 Okt 2024 00:16:02 CEST
// Last Modified: Mo 14 Okt 2024 09:21:02 CEST
// Filename: min/humlib.cpp
// URL: https://github.com/craigsapp/humlib/blob/master/min/humlib.cpp
// Syntax: C++11
Expand Down Expand Up @@ -47768,6 +47768,8 @@ void MxmlEvent::setBarlineStyle(xml_node node) {
reportMeasureStyleToOwner(MeasureStyle::RepeatBackward);
} else if (repeat == +1) {
reportMeasureStyleToOwner(MeasureStyle::RepeatForward);
} else if (barstyle == "none") {
reportMeasureStyleToOwner(MeasureStyle::Invisible);
}
}

Expand Down
2 changes: 1 addition & 1 deletion min/humlib.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//
// Programmer: Craig Stuart Sapp <craig@ccrma.stanford.edu>
// Creation Date: Sat Aug 8 12:24:49 PDT 2015
// Last Modified: Fr 11 Okt 2024 00:16:02 CEST
// Last Modified: Mo 14 Okt 2024 09:21:02 CEST
// Filename: min/humlib.h
// URL: https://github.com/craigsapp/humlib/blob/master/min/humlib.h
// Syntax: C++11
Expand Down
2 changes: 2 additions & 0 deletions src/MxmlEvent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1329,6 +1329,8 @@ void MxmlEvent::setBarlineStyle(xml_node node) {
reportMeasureStyleToOwner(MeasureStyle::RepeatBackward);
} else if (repeat == +1) {
reportMeasureStyleToOwner(MeasureStyle::RepeatForward);
} else if (barstyle == "none") {
reportMeasureStyleToOwner(MeasureStyle::Invisible);
}
}

Expand Down