chore: Developer branch for nim #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only nim will be passing tests since I changed the c function names and only modified that code to match. |
|
c functions needed to be changed because the linker was detecting duplicate symbols with c-kzg (since the c functions are named exactly the same thing) |
kevaundray
commented
Jul 1, 2024
| proc getInstallDir*(): string = | ||
| when defined(macosx): | ||
| when defined(aarch64) or defined(amd64): | ||
| when defined(aarch64) or defined(amd64) or defined(arm64): |
There was a problem hiding this comment.
In nimbus, it was returning arm64 instead of aarch64
kevaundray
force-pushed
the
kw/nim-release-branch
branch
2 times, most recently
from
1c3d0f2 to
fc339dc
Compare
|
Renaming the methods and the the nim changes can be ported to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.