Skip to content

CI/TSML: Fix Time Series builds by downgrading to Python 3.11.8 #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Apr 10, 2024

Problem

GH-403 fixed a few flaws when running Jupyter Notebooks on Google Colab, as reported by @marijaselakovic. She reported the Time Series slot also has flaws, this patch aims to mitigate them.

Solution

We are fixing this on CI/GHA by downgrading to Python 3.11.8. On Google Colab, it will work anyway because that environment is still running Python 3.10.

References

More information about why Python 3.11.9 breaks Dask:

Base automatically changed from amo/fix-dask-colab to main April 10, 2024 13:11
@amotl amotl force-pushed the amo/fix-ts-deps branch 2 times, most recently from a331bab to 31a5154 Compare April 10, 2024 13:17
@amotl amotl changed the title TSML dependencies: For dask, dask-expr, distributed, pandas, sqlalchemy CI/TSML: Fix Time Series builds Apr 10, 2024
@amotl amotl force-pushed the amo/fix-ts-deps branch from 31a5154 to 590863b Compare April 10, 2024 13:19
@amotl
Copy link
Member Author

amotl commented Apr 10, 2024

Problem

ValueError: Found array with 0 sample(s) (shape=(0, 1)) while a minimum of 1 is required by SimpleImputer.

-- https://github.com/crate/cratedb-examples/actions/runs/8631971131/job/23661528515?pr=404#step:6:910

@amotl amotl changed the title CI/TSML: Fix Time Series builds CI/TSML: Fix Time Series builds by downgrading to Python 3.11.8 Apr 10, 2024
@amotl amotl marked this pull request as ready for review April 10, 2024 13:31
@amotl amotl merged commit 710af88 into main Apr 10, 2024
@amotl amotl deleted the amo/fix-ts-deps branch April 10, 2024 13:31
@amotl amotl mentioned this pull request Apr 10, 2024
2 tasks
@amotl
Copy link
Member Author

amotl commented Apr 10, 2024

The ValueError coming from SimpleImputer might still be present, and could be an unrelated fluke?

-- https://github.com/crate/cratedb-examples/actions/runs/8632142024/job/23662092328#step:6:1499

Re-running...

-- https://github.com/crate/cratedb-examples/actions/runs/8632261164/job/23662506620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants