Skip to content

Fix deadlock between remove and pollFirstEntry #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025

Conversation

klockla
Copy link
Collaborator

@klockla klockla commented Jun 3, 2025

Fix deadlock between remove and pollFirstEntry
Resynchronize getURLs critical part
Added entrySetView in ConcurrentOrderedMap (used in listURLs and countURLs)

@klockla klockla force-pushed the fix-deadlock-122 branch 3 times, most recently from 10b2934 to a367fa1 Compare June 5, 2025 15:17
Resynchronize getURLs critical part
Added entrySetView in ConcurrentOrderedMap (used in llistURLs and countURLs)

Signed-off-by: Laurent Klock <Laurent.Klock@arhs-cube.com>
@klockla klockla force-pushed the fix-deadlock-122 branch from a367fa1 to 6e81bcc Compare June 5, 2025 15:19
@klockla klockla marked this pull request as ready for review June 5, 2025 15:26
@klockla klockla requested a review from jnioche June 5, 2025 15:26
Copy link
Collaborator

@jnioche jnioche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial review

Signed-off-by: Laurent Klock <Laurent.Klock@arhs-cube.com>
@klockla klockla force-pushed the fix-deadlock-122 branch from f73f863 to 4fa6ea1 Compare June 10, 2025 10:43
Copy link
Collaborator

@jnioche jnioche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@klockla klockla merged commit cbc7a37 into crawler-commons:master Jun 11, 2025
2 checks passed
@klockla klockla deleted the fix-deadlock-122 branch June 11, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants