Skip to content

Skip re-extract ext-imap source #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

crazywhalecc
Copy link
Owner

What does this PR do?

Fix #789 .

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • PHP_CS_FIXER_IGNORE_ENV=1 composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@crazywhalecc crazywhalecc requested a review from henderkes June 20, 2025 11:09
@henderkes
Copy link
Collaborator

imap still seems to fail, we should probably fix it a last time, but move it into unsupported/deprecated territory.

I remember the huge pain in the ass it was to get it working in the first place, no other library was that bad

@crazywhalecc
Copy link
Owner Author

That's really weird, I'll have time to look into it next week. 🫠

@henderkes
Copy link
Collaborator

I'll leave the fun of figuring out the swoole segmentation fault to you. Imap now works again.

@crazywhalecc crazywhalecc added the kind/framework Issues related to CLI app framework label Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/framework Issues related to CLI app framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Extension test failed: new LockFile seems conflict with ext-imap source strategy
2 participants