-
-
Notifications
You must be signed in to change notification settings - Fork 287
Skip re-extract ext-imap source #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
crazywhalecc
wants to merge
11
commits into
main
Choose a base branch
from
fix/ext-imap-extraction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henderkes
requested changes
Jun 20, 2025
imap still seems to fail, we should probably fix it a last time, but move it into unsupported/deprecated territory. I remember the huge pain in the ass it was to get it working in the first place, no other library was that bad |
That's really weird, I'll have time to look into it next week. 🫠 |
I'll leave the fun of figuring out the swoole segmentation fault to you. Imap now works again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #789 .
Checklist before merging
*.php
or*.json
, run them locally to ensure your changes are valid:PHP_CS_FIXER_IGNORE_ENV=1 composer cs-fix
composer analyse
composer test
bin/spc dev:sort-config
src/globals/test-extensions.php
.extension test
ortest extensions
to trigger full test suite.