Skip to content

Allow deleting pre-built or source only for del-download #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

crazywhalecc
Copy link
Owner

What does this PR do?

Allow deleting pre-built or source only for del-download:

  • bin/spc del-download --pre-built-only XXX
  • bin/spc del-download --source-only XXX

Sometimes we need to test either source or pre-built at the same time. It's just a little function to help us simplify the download procedure. (sometimes download from another side of the earth is quite slow)

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • PHP_CS_FIXER_IGNORE_ENV=1 composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@crazywhalecc crazywhalecc requested a review from henderkes June 22, 2025 08:32
@crazywhalecc crazywhalecc added the kind/framework Issues related to CLI app framework label Jun 22, 2025
Copy link
Collaborator

@henderkes henderkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a bit overkill and I probably won't ever use it given that I never use prebuilt sources, but why not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/framework Issues related to CLI app framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants