Merge pull request #14 from creately/fixes-bug-loading

Fixed issues related to loading the tracker

Author: nkmadusanka

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@creately/siddi",
-  "version": "1.0.6",
+  "version": "1.0.7",
   "description": "A convenient event tracker API which sends events to multiple consumers",
   "main": "dist/siddi.js",
   "scripts": {

package.json

@@ -3,23 +3,23 @@ import { Consumers } from '../consumers';
 describe('Consumers', () => {
   const mixpanel = {
     __loaded: true,
-    identify: () => { },
-    track: () => { },
+    identify: () => {},
+    track: () => {},
     people: {
-      set: () => { },
+      set: () => {},
     },
   };
 
   const heap = {
-    track: () => { },
-    identify: () => { },
-    addUserProperties: () => { },
+    track: () => {},
+    identify: () => {},
+    addUserProperties: () => {},
   };
 
   const amplitudeInstance = {
-    setUserId: () => { },
-    setUserProperties: () => { },
-    logEvent: () => { },
+    setUserId: () => {},
+    setUserProperties: () => {},
+    logEvent: () => {},
   };
 
   const amplitude = {
@@ -28,13 +28,13 @@ describe('Consumers', () => {
   };
 
   const outbound = {
-    identify: () => { },
-    track: () => { },
+    identify: () => {},
+    track: () => {},
   };
 
-  const snowplow = () => { };
+  const snowplow = () => {};
 
-  const ga = () => { };
+  const ga = () => {};
 
   describe('mixpanel', () => {
     beforeEach(() => {
@@ -112,7 +112,7 @@ describe('Consumers', () => {
     });
     describe('track', () => {
       beforeEach(() => {
-        heap.track = () => { };
+        heap.track = () => {};
         jest.spyOn(heap, 'track');
       });
       it('should send given tracking data', () => {
@@ -230,7 +230,7 @@ describe('Consumers', () => {
     });
     describe('track', () => {
       beforeEach(() => {
-        outbound.track = () => { };
+        outbound.track = () => {};
         jest.spyOn(outbound, 'track');
       });
       it('should send given tracking data', () => {

src/__tests__/consumers.spec.ts

@@ -24,7 +24,7 @@ declare global {
     outbound: any;
     ga: any;
     snowplow: any;
-    snowplowschema: string;//Variable which holds the schema path
+    snowplowschema: string; //Variable which holds the schema path
   }
 }
 
@@ -101,9 +101,9 @@ export const Consumers: ConsumerConfiguration = {
       eventProperties.event = eventName;
       const selfDescribingEvent = {
         schema: window.snowplowschema,
-        data: eventProperties
-      } 
-      window.snowplow( 'trackSelfDescribingEvent', selfDescribingEvent );
+        data: eventProperties,
+      };
+      window.snowplow('trackSelfDescribingEvent', selfDescribingEvent);
     },
-  }
+  },
 };

src/consumers.ts

@@ -114,7 +114,7 @@ export class Siddi {
    * @param eventName event name
    */
   private shouldTrack(consumerConfig: EventConfiguration, eventName: string): boolean {
-    const config = Object.assign(this.defaultConsumerRule, consumerConfig);
+    const config = Object.assign({}, this.defaultConsumerRule, consumerConfig);
 
     const denyOptions = config.deny;
     const allowOptions = config.allow;