Skip to content

Add more html tags in html-cheatsheet.md file #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add more html tags in html-cheatsheet.md file #101

wants to merge 2 commits into from

Conversation

Manoj0Marmat
Copy link
Contributor

Signed-off-by: Manoj Marmat manojrajput762000@gmail.com

What does this PR do?

Add content(s) #90

Description

A semantic element clearly describes its meaning to both the browser and the developer

Screenshots or Links

Screenshot 2022-10-21 at 7 36 35 PM

Checklist:

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

Thanks for joining our community - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@Manoj0Marmat
Copy link
Contributor Author

@crescentpartha hey please review it

@crescentpartha crescentpartha added hacktoberfest Hacktoberfest Participation hacktoberfest-2022 Hacktoberfest-2022 Participation 📝review-pull-request Reviewing your pull request labels Oct 21, 2022
Copy link
Owner

@crescentpartha crescentpartha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, need to fix the broken code, then modify the required changes.

Comment on lines +50 to 55
| `<aside> … </aside>` | Its a Block level element that defines content aside from the content in which it is Placed. |

| `<sub> … </sub>` | Used for writing a subscript (smaller font just below the mid-point of normal font). |
| `<sup> … </sup>` | Similar to the above tag, but for superscripting. |
| `<small> … </small>` | Reduces text size. In HTML5, it often refers to redundant or invalid information. |
| `<strong> … </strong>` | This element indicates that its contents have strong importance or urgency. Browsers usualy render the contents in bold type. |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those tags break the table format. Please Fix it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

Comment on lines +86 to +87
| `<small> ... </small>` | Defines smaller text |
| `<strong> ... </strong>` | Defines important text |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `<small> ... </small>` | Defines smaller text |
| `<strong> ... </strong>` | Defines important text |

Those tags already exist. Please delete the older ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure got it

@Manoj0Marmat Manoj0Marmat closed this by deleting the head repository Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest Participation hacktoberfest-2022 Hacktoberfest-2022 Participation 📝review-pull-request Reviewing your pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants