Skip to content

refactor: update html cheatsheet #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2022

Conversation

Manoj0Marmat
Copy link
Contributor

Signed-off-by: Manoj Marmat manojrajput762000@gmail.com

What does this PR do?

Add content(s) #90

Description

A semantic element clearly describes its meaning to both the browser and the developer

Screenshots or Links

Screenshot 2022-10-21 at 7 36 35 PM
Screenshot 2022-10-22 at 9 51 03 AM
Screenshot 2022-10-22 at 9 51 14 AM

Checklist:

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

Thanks for joining our community - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@Manoj0Marmat
Copy link
Contributor Author

@crescentpartha please review this

@crescentpartha crescentpartha added hacktoberfest Hacktoberfest Participation hacktoberfest-2022 Hacktoberfest-2022 Participation 📝review-pull-request Reviewing your pull request labels Oct 22, 2022
Copy link
Owner

@crescentpartha crescentpartha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, modify your code.

Comment on lines +80 to +85
| `<em> ... </em>` | Defines emphasized text |
| `<i> ... </i>` | Defines a part of text in an alternate voice or mood |
| `<small> ... </small>` | Defines smaller text |
| `<strong> ... </strong>` | Defines important text |
| `<sub> ... </sub>` | Defines subscripted text |
| `<sup> ... </sup>` | Defines superscripted text |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some duplicate tags. Please, rearrange and delete the duplicate tags. Your Formatting section is looking very good. If those tags already exist, then remove the older one and rearrange them like the Formatting section. Try to check your newly added tags with the original html-cheatsheet.md file. Otherwise, creating a new conflict again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already removed older repeated tags please check

@crescentpartha crescentpartha added duplicate This issue or pull request already exists modifications-needed Modify the code waiting-for-changes Waiting for require changes labels Oct 22, 2022
Copy link
Owner

@crescentpartha crescentpartha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@crescentpartha crescentpartha added the 🚀ready-to-merge Pull Request is ready to merge label Oct 22, 2022
@crescentpartha crescentpartha merged commit 0a1970e into crescentpartha:main Oct 22, 2022
@crescentpartha crescentpartha added the hacktoberfest-accepted Contributions Accepted label Oct 22, 2022
@Manoj0Marmat Manoj0Marmat deleted the newHtml branch October 23, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists hacktoberfest Hacktoberfest Participation hacktoberfest-2022 Hacktoberfest-2022 Participation hacktoberfest-accepted Contributions Accepted modifications-needed Modify the code 🚀ready-to-merge Pull Request is ready to merge 📝review-pull-request Reviewing your pull request waiting-for-changes Waiting for require changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants