Fix acts_as_tool_call message: option (#514)#515
Merged
crmne merged 2 commits intocrmne:mainfrom Mar 1, 2026
Merged
Conversation
23 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
==========================================
+ Coverage 80.95% 80.97% +0.01%
==========================================
Files 114 114
Lines 5215 5215
Branches 1353 1353
==========================================
+ Hits 4222 4223 +1
+ Misses 993 992 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes
cleanup_orphaned_tool_resultsignoring custom association names configured via acts_as_tool_call message: and acts_as_message tool_calls: options.The bug: When using custom association names like
acts_as_tool_call message: :llm_message, the cleanup method called hardcoded.messageand.tool_callsinstead of the configured association names, causing NoMethodError.The fix: Use
message_associationandtool_calls_associationmethods, which respect the configured names.Type of change
Scope check
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)API changes
Related issues
#514