rabbit: raise failure-timeout #2065
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmueller
force-pushed
the
rabbit_timings
branch
from
d4bda2f to
e7efbee
Compare
dirkmueller
force-pushed
the
rabbit_timings
branch
from
e7efbee to
4d559b3
Compare
dirkmueller
force-pushed
the
rabbit_timings
branch
from
4d559b3 to
392d019
Compare
The failure timeout of 30s is far too low. Essentially it means that a failed node is considered ready after 30s. Given that any start or stop operation takes considerably more than 30s. We should only expire failures after around 30 minutes to prevent flapping services.
JanZerebecki
force-pushed
the
rabbit_timings
branch
from
392d019 to
88ddf9f
Compare
|
Changed commit message to match regex checked by travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure timeout of 30s is far too low. Essentially it means that a
failed node is considered ready after 30s. Given that any start or
stop operation takes considerably more than 30s. We should only expire
failures after around 30 minutes to prevent flapping services.