Fix #2747: Deduplicate functions in get_msg_sender_checks to avoid repeated msg.sender condition nodes #2748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid repeated msg.sender conditions Fix: Deduplicate functions in get_msg_sender_checks to avoid repeated msg.sender conditions (crytic#2747) This resolves an issue where the `authorization` printer would output duplicate msg.sender checks due to modifiers being included both in `function.all_internal_calls()` and explicitly in `function.modifiers`. ✅ Applied Fix (safe): - Wraps the combined function list in a `set()` to deduplicate `Function` instances. - Ensures complete analysis while avoiding repeated conditions in output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Deduplicate functions in get_msg_sender_checks to avoid repeated msg.sender condition nodes (#2747)
✅ Applied Fix (safe & immediate):
set()to deduplicateFunctioninstances.function.modifiersinall_functionscould also prevent duplicates,but risks missing edge cases where a modifier is attached but not present in internal calls.
The current fix ensures correctness, safety, and consistent analysis output.