fix: correct Vyper function parameter types in canonical_name#2965
Open
jose-blockchain wants to merge 3 commits intocrytic:masterfrom
Open
fix: correct Vyper function parameter types in canonical_name#2965jose-blockchain wants to merge 3 commits intocrytic:masterfrom
jose-blockchain wants to merge 3 commits intocrytic:masterfrom
Conversation
canonical_name and full_name were cached before parameter types were resolved during Vyper parsing, producing signatures like f() instead of f(bytes[1024]). After analyze_content resolves all types, invalidate the stale caches and rebuild the contract function dict with correct keys. Closes crytic#2796 Co-authored-by: Cursor <cursoragent@cursor.com>
|
|
Author
|
pls review @Subway2023 |
canonical_name and full_name were cached before parameter types were resolved during Vyper parsing, producing signatures like f() instead of f(bytes[1024]). After analyze_content resolves all types, invalidate the stale caches and rebuild the contract function dict with correct keys. Closes crytic#2796 Co-authored-by: Cursor <cursoragent@cursor.com>
…m/jose-blockchain/slither into fix/vyper-function-params-ir-2796
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2796
canonical_nameandfull_namewere cached duringparse_functions()beforeanalyze_params()/analyze_content()resolved parameter types, producing signatures likef()instead off(bytes[1024]).Added
_rebind_functions()at the end ofanalyze()to invalidate stale caches and rebuild the contract function dict with correct keys. Includes regression test and updated e2e snapshots.