-
Notifications
You must be signed in to change notification settings - Fork 41
Refactor schedule-precedence to allow user overrides #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch modifies the manager deployment to include the default ConfigMap for csi-addons.
Having it this way will enable us to configure default values on Install without requiring any code changes. It will also enable us to have different values if needed between upstream and downstream.
If it comes in as part of csv or install yamls, won't the default values override whatever values the user has set in the configmap during upgrade ?
If we are not creating the configmap by default, we should not enforce for the creation, whoever is creating the CM should add the value. For upstream, we can update the document if required to update it. What are the side effect and possibilities of updating the default in the commandline itself? |
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
This patch refactors the schedule-precedence logic to allow the value to be overridden by a ConfigMap. The default mode of operation still prefers PVCs first as source of key rotation and reclaimspace annotations. The values for `schedule-precedence` keys are now concretely defined as either `pvc` or `storageclass`. Signed-off-by: Niraj Yadav <niryadav@redhat.com>
c824a1c
to
2258621
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@black-dragon74 ,
Can you please add a PendingReleaseNotes.md file similar to the one we have at CephCSI and document this change in it ?
PendingReleaseNotes.md
Outdated
- allow override of precedence of key rotation and reclaim space related annotations | ||
using a ConfigMap key `schedule-precedence`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention possible values and default in this point itself.
Add a sentence mentioned "sc-only" option is deprecated and will be removed in next release.
This patch adds PendingReleaseNotes to track upcoming changes in release notes. Signed-off-by: Niraj Yadav <niryadav@redhat.com>
d40b080
to
a724eae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This patch refactors the schedule-precedence logic
to allow the value to be overridden by a ConfigMap.
The default mode of operation still prefers PVCs first
as source of key rotation and reclaimspace annotations.
The values for
schedule-precedence
keys are now concretelydefined as either
pvc
orstorageclass
.