-
Notifications
You must be signed in to change notification settings - Fork 41
mergify: fix mergify config #823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix deprecated mergify config Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
The mergify check fails for current config, but passes for the new config. |
@Nikhil-Ladha do we have link to this config deprecation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config LGTM.
Actually, I noticed there is a PR from Mergify to update the config - #712
Can you compare your PR with it?
I couldn't find a link in the release docs or so, but the CI is failing with the details, as mentioned in my previous comment. |
It has a similar change for the 2 fields which this PR adds, so we are good wrt that. |
I think will need to merge it manually. @Rakshith-R PTAL |
@Mergifyio queue Not sure this works... |
🟠 Waiting for conditions to match
|
fix deprecated mergify config