Add new status conditions to replication status #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
api
mergify
bot
requested review from
Madhu-1,
nixpanic,
Rakshith-R,
ShyamsundarR,
black-dragon74,
iPraveenParihar and
yati1998
Madhu-1
reviewed
Jun 27, 2025
internal/controller/replication.storage/volumereplication_controller.go
Outdated
Show resolved
Hide resolved
|
@ShyamsundarR PTAL. @Nikhil-Ladha please check with Ramen team to ensure there is no regression in Ramen because of new condition |
Nikhil-Ladha
force-pushed
the
add-state-condition
branch
from
164e12f to
3de7136
Compare
From what I have understood, ramen checks for individual conditions from VR status, so a new condition won't hamper anything unless used explicitly. But, I will still let @ShyamsundarR confirm on the same. |
Nikhil-Ladha
force-pushed
the
add-state-condition
branch
from
3de7136 to
b02620d
Compare
nixpanic
reviewed
Jul 1, 2025
update csi-addons/spec pkg to include latest GetVolumeReplicationInfo RPC updates Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
update GetVolumeReplicationInfo RPC proto definition as per the csi-addons/spec changes to include Status and StatusMessage fields in the response Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
Nikhil-Ladha
force-pushed
the
add-state-condition
branch
from
b02620d to
b162e14
Compare
Nikhil-Ladha
force-pushed
the
add-state-condition
branch
from
b162e14 to
8330c00
Compare
|
Updated the sidecar code to return the new status fields in the response. Test results: |
|
If everything looks can we get this PR merged, so that ramen PR can also be reviewed and tested? |
Madhu-1
reviewed
Jul 7, 2025
add replication status condition to VR Status which helps in understanding the current replication state of the image/group Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
Nikhil-Ladha
force-pushed
the
add-state-condition
branch
from
8330c00 to
2769399
Compare
Madhu-1
approved these changes
Jul 8, 2025
nixpanic
reviewed
Jul 8, 2025
nixpanic
approved these changes
Jul 10, 2025
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new status conditions which reflect the current replication status as returned from the storage vendor.