Add support for inline attachments in HTML mails #119
Conversation
|
@Tangresh |
|
Sure! The Content-ID is the identifier by which the images can be referenced and is set as |
|
@Tangresh Can you please rebase on master to fix conflicts ? 🙏 |
Tangresh
force-pushed
the
inline-attachments
branch
from
5ef6bc7 to
59d426a
Compare
|
@ctabin Done Edit: That was sloppy of me, I'll have to fix that commit again. |
Tangresh
force-pushed
the
inline-attachments
branch
from
59d426a to
3d2caab
Compare
|
I have also tested my application with your updated master branch, looks like everything is still working. |
|
@Tangresh Thank you very much ! Yes I plan to integrate your PR and I'll do a new release right after. |
|
|
||
| final List<OutlookMessageAttachment> regularAttachments = getAttachments().stream() | ||
| .filter(att -> att.getContentId() == null) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
Let's use JDK21.
| .collect(Collectors.toList()); | |
| .toList(); |
|
|
||
| final List<OutlookMessageAttachment> inlineAttachments = getAttachments().stream() | ||
| .filter(att -> att.getContentId() != null) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
| .collect(Collectors.toList()); | |
| .toList(); |
| } | ||
| else { |
There was a problem hiding this comment.
| } | |
| else { | |
| } else { |
| message.setReplyTo(Arrays.asList("reply1@jotlmsg.com", "reply2@jotlmsg.com")); | ||
| message.setPlainTextBody("Hello,\n\nThis is a simple message.\n\n.Bye."); | ||
| message.setHtmlBody("<html><body>Simple body</body></html>"); | ||
| message.addRecipient(OutlookMessageRecipient.Type.TO, "cedric@jotlmsg.com", "Cédric"); | ||
| final OutlookMessageAttachment inlineAttachment = new OutlookMessageAttachment("picture.png", "image/png", new ByteArrayInputStream(new byte[0])); | ||
| inlineAttachment.setContentId("picture.png"); |
There was a problem hiding this comment.
Could you make a test without the plain text and with an html part actually using linking the png to show how it works ?
This PR adds support for inline attachment support in HTML emails.
I am not entirely happy with the API as it is, where the contentId property has to be set with a setter on the OutlookMessageAttachment and the contentId is the only thing distinguishing it from a regular attachment.
Maybe they should be saved in a Map in the OutlookMessage, because one does not want multiple inline attachments with the same contentId?