fix(FilterListBox): filtering issue #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: ac15702 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📦 NPM canary releaseDeployed canary version 0.0.0-canary-8ac2e3b. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
🧪 Storybook is successfully deployed!
|
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Fixes FilterListBox filtering by delegating empty-state handling to ListBox via a new emptyLabel prop, showing “No results found” vs “No items” appropriately.
FilterListBox(src/components/fields/FilterListBox/FilterListBox.tsx):hasResults/showEmptyMessagelogic and always rendersListBox.emptyLabelbased onsearchValue("No results found" when searching, else "No items").filterFnand forwardsstateReffor accurate filtered collection.ListBox(src/components/fields/ListBox/ListBox.tsx):emptyLabelprop and renders an empty-state row whencollection.size === 0.@cube-dev/ui-kitnoting the FilterListBox filtering fix.Written by Cursor Bugbot for commit ac15702. This will update automatically on new commits. Configure here.