feat(cubesql): Support MEASURE SQL push down
#8606
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8606 +/- ##
==========================================
+ Coverage 82.66% 82.69% +0.03%
==========================================
Files 217 217
Lines 78125 78272 +147
==========================================
+ Hits 64583 64729 +146
- Misses 13542 13543 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ovr
approved these changes
Aug 21, 2024
MazterQyou
force-pushed
the
cubesql/measure-func-error
branch
from
12f71bf to
89ec530
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
MazterQyou
changed the title
MEASURE function push downMEASURE SQL push down
MazterQyou
force-pushed
the
cubesql/measure-func-error
branch
from
89ec530 to
4968959
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This PR adds push down for
MEASUREaggregate function, replacing it with the aggregate function of the respective measure. It additionally improves error thrown byMEASUREfunction when it cannot be pushed down (the original error thrown wasoneshot cancelled, which does not help). The new error message should help users resolve the issue themselves should they stumble upon it.