ci(cubesql): Attach cubenativeutils and cubesqlplanner to cargo fmt and cargo check #8677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8677 +/- ##
=======================================
Coverage 84.17% 84.17%
=======================================
Files 230 230
Lines 85112 85112
=======================================
+ Hits 71643 71647 +4
+ Misses 13469 13465 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mcheshkov
force-pushed
the
more-workspaces-in-ci
branch
from
8433087 to
30d1318
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
mcheshkov
force-pushed
the
more-workspaces-in-ci
branch
4 times, most recently
from
e75c869 to
92f7495
Compare
mcheshkov
force-pushed
the
more-workspaces-in-ci
branch
from
92f7495 to
9041c11
Compare
KSDaemon
force-pushed
the
more-workspaces-in-ci
branch
from
9041c11 to
fe8d90a
Compare
marianore-muttdata
pushed a commit
to MuttData/cube
that referenced
this pull request
Jun 17, 2025
…nd cargo check (cube-js#8677) * ci(cubesql): Attach cubenativeutils and cubesqlplanner to cargo clippy * fix some clippy warnings and allow the rest. * cargo fmt --all --------- Co-authored-by: Konstantin Burkalev <KSDaemon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
Those are separate workspaces, with separate Cargo.lock, so we should at least check that lockfiles are up to date