Skip to content

Conversation

@MazterQyou
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR adds an optimizer that splits meta filters (WHERE __user...) into a separate Filter node. This helps with queries where filter contains expressions that cannot be pushed down to CubeScan. In this case SQL push down is applied but meta filters should go into CubeScan anyway. Related tests are included.

@MazterQyou MazterQyou requested a review from a team as a code owner October 14, 2024 18:24
@codecov
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 95.34884% with 12 lines in your changes missing coverage. Please review.

Project coverage is 83.69%. Comparing base (9d1c3f8) to head (6e1a008).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../compile/engine/df/optimizers/filter_split_meta.rs 94.82% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8812      +/-   ##
==========================================
+ Coverage   83.65%   83.69%   +0.03%     
==========================================
  Files         227      228       +1     
  Lines       81773    82016     +243     
==========================================
+ Hits        68409    68640     +231     
- Misses      13364    13376      +12     
Flag Coverage Δ
cubesql 83.69% <95.34%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mcheshkov mcheshkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rebase on fresh master and land it

@MazterQyou MazterQyou force-pushed the cubesql/where-user-sql-push-down branch from 0adfa60 to 29a1f1e Compare February 26, 2025 17:12
@MazterQyou MazterQyou force-pushed the cubesql/where-user-sql-push-down branch from 29a1f1e to 6e1a008 Compare February 26, 2025 17:21
@MazterQyou MazterQyou merged commit 83baf7b into master Feb 26, 2025
70 checks passed
@MazterQyou MazterQyou deleted the cubesql/where-user-sql-push-down branch February 26, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants