Skip to content

Conversation

@ovr
Copy link
Member

@ovr ovr commented Oct 16, 2024

No description provided.

@vercel
Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 0:08am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 0:08am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 0:08am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 0:08am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 0:08am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 0:08am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 0:08am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 0:08am

@ovr ovr requested a review from a team as a code owner October 16, 2024 12:01
@ovr ovr force-pushed the refactor/query-router-no-recursion branch from 768be52 to 8f68d51 Compare October 16, 2024 12:08
@codecov
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 82.74%. Comparing base (5935964) to head (8f68d51).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/router.rs 70.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8820      +/-   ##
==========================================
- Coverage   82.75%   82.74%   -0.02%     
==========================================
  Files         219      219              
  Lines       78235    78236       +1     
==========================================
- Hits        64745    64737       -8     
- Misses      13490    13499       +9     
Flag Coverage Δ
cubesql 82.74% <70.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovr ovr merged commit f4b03f2 into master Oct 16, 2024
70 of 71 checks passed
@ovr ovr deleted the refactor/query-router-no-recursion branch October 16, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants