fix(cubesql): Calculate proper limit and offset for CubeScan in nested limits case #8924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8924 +/- ##
==========================================
+ Coverage 83.75% 83.81% +0.06%
==========================================
Files 228 229 +1
Lines 82334 82658 +324
==========================================
+ Hits 68961 69283 +322
- Misses 13373 13375 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
mcheshkov
force-pushed
the
push-cubescan-limit-calc
branch
5 times, most recently
from
80ea85b to
f926c8c
Compare
mcheshkov
force-pushed
the
push-cubescan-limit-calc
branch
from
f926c8c to
4e244c9
Compare
mcheshkov
force-pushed
the
push-cubescan-limit-calc
branch
from
4e244c9 to
84660d1
Compare
mcheshkov
force-pushed
the
push-cubescan-limit-calc
branch
6 times, most recently
from
0c9d56b to
08ca4aa
Compare
mcheshkov
force-pushed
the
push-cubescan-limit-calc
branch
from
08ca4aa to
7d5428b
Compare
mcheshkov
force-pushed
the
push-cubescan-limit-calc
branch
from
7d5428b to
e7bdba1
Compare
MazterQyou
approved these changes
Mar 5, 2025
mcheshkov
force-pushed
the
push-cubescan-limit-calc
branch
from
e7bdba1 to
1d20d1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
Before this in
Limit(Limit(CubeScan))logical plan outer fetch and skip values would win.Not they are calculated properly.