Skip to content

Conversation

@ChrisLahaye
Copy link

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#9015

Description of Changes Made (if issue reference is not provided)

Add Cube.js MongoDB Database Driver

Signed-off-by: Chris Lahaye <mail@chrislahaye.com>
@ChrisLahaye ChrisLahaye requested review from a team as code owners December 19, 2024 22:43
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Dec 19, 2024
@igorlukanin
Copy link
Member

Hi @ChrisLahaye 🙌

Thanks for your contribution! I feel like we'd need integrations tests to make sure this one works.

Also, did you have a chance to publish this as a separate NPM package? Then we can put it under the list of third-party drivers, as suggested by the contribution policy.

@igorlukanin igorlukanin added the driver:mongodb Issues relating to the MongoBI driver label Jan 8, 2025
@KSDaemon
Copy link
Member

KSDaemon commented Mar 7, 2025

Hi @ChrisLahaye ! 🙌

Thank you for your contribution!
However, as @igorlukanin correctly noted - we definitely need at least basic integration tests for this to be landed. In other cases, we can't guarantee it is working or will be working with future updates in the project.

Don't worry if you haven't done it before. It's not so hard! You need to spin up a MongoDB docker container and run a few basic queries against it. Please, have a look at some existing integrations as examples:

TLDR; Version:

  1. Add MongoDBRunner to @cubejs-backend/testing-shared
  2. Create a few basic tests (create table, do some basic queries) along the lines of PostgresDriver.test
  3. Add integration:mongo script or smth like that to package.json
  4. And add it to CI push workflow.

Feel free to ask any help if needed.

@igorlukanin igorlukanin added driver:mongodb Issues relating to the MongoBI driver and removed driver:mongodb Issues relating to the MongoBI driver labels Jun 9, 2025
@igorlukanin igorlukanin assigned igorlukanin and unassigned KSDaemon Jun 9, 2025
@igorlukanin
Copy link
Member

It is better to pursue native, non-JDBC implementations of data source drivers: 3f71e56

@igorlukanin igorlukanin closed this Jun 9, 2025
@fabianboerner
Copy link

@igorlukanin what does it mean native, you want to have a translator from sql into mongodb aggregation via typescript?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data source driver driver:mongodb Issues relating to the MongoBI driver pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants