Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Mar 25, 2025

This PR fixes a bunch of issues related to cube inheritance. Among them are:

Also included:

  • Additional tests for folders
  • Additional tests for hierarchies
  • Additional tests for accessPolicies
  • Tuned schema validator to gather all model errors instead of throwing only the first one. So now, if your model has more then one error - you'll see them all at once instead of fixing them one-by-one.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Supersedes #8970

Closes #9269, #7137, #8519, #8609, #8970

@KSDaemon KSDaemon marked this pull request as ready for review March 25, 2025 17:55
@KSDaemon KSDaemon requested a review from a team as a code owner March 25, 2025 17:55
@KSDaemon KSDaemon requested a review from a team as a code owner March 27, 2025 21:05
@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.05%. Comparing base (610820f) to head (7d8b19a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...cubejs-schema-compiler/src/compiler/CubeSymbols.ts 96.42% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9386      +/-   ##
==========================================
+ Coverage   47.85%   48.05%   +0.19%     
==========================================
  Files         171      171              
  Lines       21422    21453      +31     
  Branches     3711     3722      +11     
==========================================
+ Hits        10252    10309      +57     
+ Misses      10738    10712      -26     
  Partials      432      432              
Flag Coverage Δ
cube-backend 48.05% <98.21%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon merged commit 409d74d into master Apr 11, 2025
59 checks passed
@KSDaemon KSDaemon deleted the fix/inheritance branch April 11, 2025 15:29
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
* some improvements in transformYamlCubeObj()

* implement inheritance for preaggs & DAPs

* rename prepareCompiler → prepareJsCompiler() in tests

* add tests for inheritance

* hide sql prop from parent cube if needed

* add tests for sql override

* fix pre-aggs inheritance

* fix test

* remove unneeded

* add more tests for views and errors

* fix preaggs again

* mooooore tests :)

* more test coverage

* more tests for folders

* remove useless check

* just refactoring

* fix schema validation for extended cubes

* add tests

* update joi to the latest

* fix tests

* add tests for pre-aggs

* fix test

* fix tests

* fix snapshots after merge changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pre-aggregations are not inherited via extends in YAML-based models

3 participants