-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(schema-compiler): Fix cubes inheritance #9386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54f2c7f to
97d9573
Compare
0ed3c9b to
01f377f
Compare
dbf8633 to
1a403ec
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9386 +/- ##
==========================================
+ Coverage 47.85% 48.05% +0.19%
==========================================
Files 171 171
Lines 21422 21453 +31
Branches 3711 3722 +11
==========================================
+ Hits 10252 10309 +57
+ Misses 10738 10712 -26
Partials 432 432
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ovr
reviewed
Apr 11, 2025
ovr
approved these changes
Apr 11, 2025
1a403ec to
619a1af
Compare
56b0c20 to
7d8b19a
Compare
This was referenced Apr 14, 2025
marianore-muttdata
pushed a commit
to MuttData/cube
that referenced
this pull request
Jun 17, 2025
* some improvements in transformYamlCubeObj() * implement inheritance for preaggs & DAPs * rename prepareCompiler → prepareJsCompiler() in tests * add tests for inheritance * hide sql prop from parent cube if needed * add tests for sql override * fix pre-aggs inheritance * fix test * remove unneeded * add more tests for views and errors * fix preaggs again * mooooore tests :) * more test coverage * more tests for folders * remove useless check * just refactoring * fix schema validation for extended cubes * add tests * update joi to the latest * fix tests * add tests for pre-aggs * fix test * fix tests * fix snapshots after merge changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bunch of issues related to cube inheritance. Among them are:
Also included:
Check List
Supersedes #8970
Closes #9269, #7137, #8519, #8609, #8970