Skip to content

Conversation

@KSDaemon
Copy link
Member

  • update "@types/node" → v20
  • update node-check
  • add deprecation for node v20 in deprecation.md
  • update node version in ci

@codecov
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.54%. Comparing base (55c5a95) to head (a6a50be).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
packages/cubejs-backend-shared/src/node-check.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9402       +/-   ##
===========================================
+ Coverage   47.90%   76.54%   +28.63%     
===========================================
  Files         171      400      +229     
  Lines       21425   104970    +83545     
  Branches     3713     3713               
===========================================
+ Hits        10264    80347    +70083     
- Misses      10728    24190    +13462     
  Partials      433      433               
Flag Coverage Δ
cube-backend 47.90% <33.33%> (-0.01%) ⬇️
cubesql 83.88% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review March 28, 2025 15:25
@KSDaemon KSDaemon requested review from a team as code owners March 28, 2025 15:25
@ovr
Copy link
Member

ovr commented Mar 28, 2025

@KSDaemon What about docker files?

@KSDaemon
Copy link
Member Author

@ovr good addition, thnx! I forgot about them initially, but they are in my queue!

@ovr
Copy link
Member

ovr commented Mar 31, 2025

@KSDaemon, could you please update @types/node in the resolutions section of the packages.json files in the root directory? And regenerate yarn.lock file. Thanks

@KSDaemon
Copy link
Member Author

@ovr fixed!

@KSDaemon KSDaemon force-pushed the depr/node-v20-depr branch from 04d84bf to a6a50be Compare April 11, 2025 09:29
@KSDaemon KSDaemon merged commit 455174b into master Apr 11, 2025
80 checks passed
@KSDaemon KSDaemon deleted the depr/node-v20-depr branch April 11, 2025 10:47
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
* update "@types/node" → v20

* update node-check

* add deprecation for node v20 in deprecation.md

* update node version in ci

* add todo

* update node version in docker images

* fix node types resolutions

* regenerate yarn.lock

* more comments in CI

* add note about v18 depr

* another type fix

* upgrade angular

� Conflicts:
�	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants