Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Apr 9, 2025

This is a follow-up PR of the original #9407 by @qiao-x with some minor fixes and setup of CI tests.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Closes #9407, #9393

@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.88%. Comparing base (455174b) to head (c8242a7).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (455174b) and HEAD (c8242a7). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (455174b) HEAD (c8242a7)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9445       +/-   ##
===========================================
- Coverage   76.54%   47.88%   -28.66%     
===========================================
  Files         400      171      -229     
  Lines      104956    21412    -83544     
  Branches     3707     3707               
===========================================
- Hits        80341    10254    -70087     
+ Misses      24183    10726    -13457     
  Partials      432      432               
Flag Coverage Δ
cube-backend 47.88% <ø> (ø)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@qiao-x
Copy link
Contributor

qiao-x commented Apr 9, 2025

@KSDaemon last time i met a problem when testing export to GCS originated from master branch. #9393 (comment)

I suspect it's due to some code change on base driver or something because last time i only replace databricks driver to test. Wonder will there be an image pushed for this branch which i can test it in my env?

@KSDaemon KSDaemon marked this pull request as ready for review April 9, 2025 10:28
@KSDaemon KSDaemon requested review from a team as code owners April 9, 2025 10:28
@KSDaemon
Copy link
Member Author

KSDaemon commented Apr 9, 2025

@qiao-x If I remember correctly, you can grab an image from the Action's run page artifacts: https://github.com/cube-js/cube/actions/runs/14354380161?pr=9445

@qiao-x
Copy link
Contributor

qiao-x commented Apr 9, 2025

docker pull cubejs/cube:testing-drivers

this one? we have to use one with -jdk prefix (v1.2.27-jdk in our env), not sure this one will work or not.

@KSDaemon
Copy link
Member Author

KSDaemon commented Apr 9, 2025

@qiao-x testing-drivers includes jdk.

@KSDaemon
Copy link
Member Author

KSDaemon commented Apr 9, 2025

@qiao-x But I was actually talking about this :)
Снимок экрана 2025-04-09 в 15 21 46

@qiao-x
Copy link
Contributor

qiao-x commented Apr 10, 2025

@qiao-x But I was actually talking about this :) Снимок экрана 2025-04-09 в 15 21 46

isn't this image artifacts the same as the one pushed into docker repositry? I just test pulling from cubejs/cube:testing-drivers and got an error like below, Do I have to download the image artifacts file to test?

Cube Error ---------------------------------------
Error: Unable to load Python configuration because you are using the fallback build of native extension. Read more: https://github.com/cube-js/cube/blob/master/packages/cubejs-backend-native/README.md#supported-architectures-and-platforms
    at ServerContainer.lookupConfiguration (/cubejs/packages/cubejs-server/src/server/container.ts:280:15)
    at makeInstance (/cubejs/packages/cubejs-server/src/server/container.ts:380:37)
    at ServerContainer.start (/cubejs/packages/cubejs-server/src/server/container.ts:401:26)
    at Server.run (/cubejs/packages/cubejs-server/src/command/server.ts:25:21)
    at Command.<anonymous> (/cubejs/packages/cubejs-cli/src/command/proxy-command.ts:51:13)
Need some help? -------------------------------------
  Ask this question in Cube Slack: https://slack.cube.dev
  Post an issue: https://github.com/cube-js/cube.js/issues

@KSDaemon
Copy link
Member Author

@qiao-x ah... I see... the testing-drivers image is being built without python support. That is what it is complaining for...

@qiao-x
Copy link
Contributor

qiao-x commented Apr 11, 2025

LOL, then I don't know how to test it in our GCP Databricks env. Maybe I can only try it with master branch's image after merged and report any issues found.

@KSDaemon
Copy link
Member Author

@qiao-x eh) Then yeah, you can try latest after we merge it into the master. Would be awesome if you'll try and post a note: ok/fails.

@KSDaemon KSDaemon force-pushed the qiao-x-feature/gcs-export-bucket branch from 4d0b089 to c8242a7 Compare April 11, 2025 10:49
@KSDaemon KSDaemon merged commit a247bf9 into master Apr 11, 2025
69 checks passed
@KSDaemon KSDaemon deleted the qiao-x-feature/gcs-export-bucket branch April 11, 2025 11:13
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
…oud Storage (cube-js#9445)

* Databricks export bucket for google cloud storage

* simplify docs

* add correct search prefix and filter after extract

* rollback tableFullName construction

* abstract out the bucket type array

* some fixes and code polishment

* prepare CI

* add docs

* remove copy-paste

---------

Co-authored-by: qiao-x <105260504+qiao-x@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants