-
Couldn't load subscription status.
- Fork 1.9k
feat(databricks-jdbc-driver): Add export bucket support for Google Cloud Storage #9445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9445 +/- ##
===========================================
- Coverage 76.54% 47.88% -28.66%
===========================================
Files 400 171 -229
Lines 104956 21412 -83544
Branches 3707 3707
===========================================
- Hits 80341 10254 -70087
+ Misses 24183 10726 -13457
Partials 432 432
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@KSDaemon last time i met a problem when testing export to GCS originated from master branch. #9393 (comment) I suspect it's due to some code change on base driver or something because last time i only replace databricks driver to test. Wonder will there be an image pushed for this branch which i can test it in my env? |
|
@qiao-x If I remember correctly, you can grab an image from the Action's run page artifacts: https://github.com/cube-js/cube/actions/runs/14354380161?pr=9445 |
this one? we have to use one with |
|
@qiao-x |
|
@qiao-x But I was actually talking about this :) |
isn't this image artifacts the same as the one pushed into docker repositry? I just test pulling from |
|
@qiao-x ah... I see... the |
|
LOL, then I don't know how to test it in our GCP Databricks env. Maybe I can only try it with master branch's image after merged and report any issues found. |
|
@qiao-x eh) Then yeah, you can try |
docs/pages/product/configuration/data-sources/databricks-jdbc.mdx
Outdated
Show resolved
Hide resolved
packages/cubejs-testing-drivers/test/databricks-jdbc-export-bucket-gcs-prefix-full.test.ts
Show resolved
Hide resolved
4d0b089 to
c8242a7
Compare
…oud Storage (cube-js#9445) * Databricks export bucket for google cloud storage * simplify docs * add correct search prefix and filter after extract * rollback tableFullName construction * abstract out the bucket type array * some fixes and code polishment * prepare CI * add docs * remove copy-paste --------- Co-authored-by: qiao-x <105260504+qiao-x@users.noreply.github.com>


This is a follow-up PR of the original #9407 by @qiao-x with some minor fixes and setup of CI tests.
Check List
Closes #9407, #9393