Skip to content

fix(schema-compiler): Fix incorrect transpilation of yaml models #9465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

fix(schema-compiler): Fix incorrect transpilation of yaml models #9465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 6 additions & 23 deletions packages/cubejs-schema-compiler/src/compiler/YamlCompiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,29 +127,12 @@ export class YamlCompiler {
private transformYamlCubeObj(cubeObj, errorsReport: ErrorReporter) {
camelizeCube(cubeObj);

if (cubeObj.measures) {
cubeObj.measures = this.yamlArrayToObj(cubeObj.measures, 'measure', errorsReport);
}

if (cubeObj.dimensions) {
cubeObj.dimensions = this.yamlArrayToObj(cubeObj.dimensions, 'dimension', errorsReport);
}

if (cubeObj.segments) {
cubeObj.segments = this.yamlArrayToObj(cubeObj.segments, 'segment', errorsReport);
}

if (cubeObj.preAggregations) {
cubeObj.preAggregations = this.yamlArrayToObj(cubeObj.preAggregations, 'preAggregation', errorsReport);
}

if (cubeObj.joins) {
cubeObj.joins = this.yamlArrayToObj(cubeObj.joins, 'join', errorsReport);
}

if (cubeObj.hierarchies) {
cubeObj.hierarchies = this.yamlArrayToObj(cubeObj.hierarchies, 'hierarchies', errorsReport);
}
cubeObj.measures = this.yamlArrayToObj(cubeObj.measures || [], 'measure', errorsReport);
cubeObj.dimensions = this.yamlArrayToObj(cubeObj.dimensions || [], 'dimension', errorsReport);
cubeObj.segments = this.yamlArrayToObj(cubeObj.segments || [], 'segment', errorsReport);
cubeObj.preAggregations = this.yamlArrayToObj(cubeObj.preAggregations || [], 'preAggregation', errorsReport);
cubeObj.joins = this.yamlArrayToObj(cubeObj.joins || [], 'join', errorsReport);
cubeObj.hierarchies = this.yamlArrayToObj(cubeObj.hierarchies || [], 'hierarchies', errorsReport);

return this.transpileYaml(cubeObj, [], cubeObj.name, errorsReport);
}
Expand Down
77 changes: 77 additions & 0 deletions packages/cubejs-schema-compiler/test/unit/yaml-schema.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,83 @@ describe('Yaml Schema Testing', () => {
}
});

it('empty (null) dimensions', async () => {
const { compiler } = prepareYamlCompiler(
`cubes:
- name: Users
sql: SELECT * FROM e2e.users
dimensions:
`
);

await compiler.compile();
});

it('empty (null) measures', async () => {
const { compiler } = prepareYamlCompiler(
`cubes:
- name: Users
sql: SELECT * FROM e2e.users
measures:
`
);

await compiler.compile();
});

it('empty (null) segments', async () => {
const { compiler } = prepareYamlCompiler(
`cubes:
- name: Users
sql: SELECT * FROM e2e.users
segments:
`
);

await compiler.compile();
});

it('empty (null) preAggregations', async () => {
const { compiler } = prepareYamlCompiler(
`cubes:
- name: Users
sql: SELECT * FROM e2e.users
dimensions: []
measures: []
segments: []
preAggregations:
joins: []
hierarchies: []
`
);

await compiler.compile();
});

it('empty (null) joins', async () => {
const { compiler } = prepareYamlCompiler(
`cubes:
- name: Users
sql: SELECT * FROM e2e.users
joins:
`
);

await compiler.compile();
});

it('empty (null) hierarchies', async () => {
const { compiler } = prepareYamlCompiler(
`cubes:
- name: Users
sql: SELECT * FROM e2e.users
hierarchies:
`
);

await compiler.compile();
});

it('unnamed measure', async () => {
const { compiler } = prepareYamlCompiler(
`cubes:
Expand Down
Loading