Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Apr 23, 2025

Fixes timeshift measure inheritance within views.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.97%. Comparing base (4c1520e) to head (e9a9a0a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...cubejs-schema-compiler/src/compiler/CubeSymbols.ts 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9504      +/-   ##
==========================================
+ Coverage   58.94%   58.97%   +0.02%     
==========================================
  Files         153      153              
  Lines       13049    13053       +4     
  Branches     2208     2212       +4     
==========================================
+ Hits         7692     7698       +6     
+ Misses       5044     5040       -4     
- Partials      313      315       +2     
Flag Coverage Δ
cube-backend 58.97% <60.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review April 23, 2025 11:18
@KSDaemon KSDaemon requested a review from a team as a code owner April 23, 2025 11:18
@KSDaemon KSDaemon merged commit 9319b0d into master Apr 23, 2025
62 checks passed
@KSDaemon KSDaemon deleted the fix/views-extends branch April 23, 2025 11:19
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
* fix(schema-compiler): Fix not working timeshift in views

* add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants