fix(cubesql): Fix sort push down projection on complex expressions #9787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9787 +/- ##
=======================================
Coverage 84.31% 84.31%
=======================================
Files 234 234
Lines 86951 86954 +3
=======================================
+ Hits 73314 73317 +3
Misses 13637 13637
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KSDaemon
force-pushed
the
cubesql/fix-sort-push-down-complex-expr
branch
from
3d7ca8a to
454ff2e
Compare
Frank-TXS
pushed a commit
to Helge-TXS/cube
that referenced
this pull request
Aug 5, 2025
…ube-js#9787) * fix(cubesql): Fix sort push down projection on complex expressions Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com> * temp switch to macos14 for gh ci runner --------- Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com> Co-authored-by: Konstantin Burkalev <KSDaemon@gmail.com>
igorlukanin
pushed a commit
that referenced
this pull request
Oct 29, 2025
…9787) * fix(cubesql): Fix sort push down projection on complex expressions Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com> * temp switch to macos14 for gh ci runner --------- Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com> Co-authored-by: Konstantin Burkalev <KSDaemon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This PR workarounds an issue with recently introduced Limit-Sort push down Projection rules, throwing an error when sort column has been replaced with a complex expression and SQL push down is involved. This is a bug in SQL push down generation, so for now only expressions that resolve to columns are being pushed down.