Skip to content

chore(cubestore): Track op name for out of queue operations #9887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

chore(cubestore): Track op name for out of queue operations #9887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions rust/cubestore/cubestore/src/cachestore/cache_eviction_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ impl CacheEvictionManager {
store: &Arc<RocksStore>,
) -> Result<KeysVector, CubeError> {
let (expired, stats_total_keys, stats_total_raw_size) = store
.read_operation_out_of_queue(move |db_ref| {
.read_operation_out_of_queue("collect_stats_and_expired_keys", move |db_ref| {
let mut stats_total_keys: u32 = 0;
let mut stats_total_raw_size: u64 = 0;

Expand Down Expand Up @@ -624,7 +624,7 @@ impl CacheEvictionManager {
let eviction_proactive_size_threshold = self.eviction_proactive_size_threshold;

let (all_keys, stats_total_keys, stats_total_raw_size, expired_keys) = store
.read_operation_out_of_queue(move |db_ref| {
.read_operation_out_of_queue("collect_allkeys_to_evict", move |db_ref| {
let mut stats_total_keys: u32 = 0;
let mut stats_total_raw_size: u64 = 0;

Expand Down Expand Up @@ -768,7 +768,7 @@ impl CacheEvictionManager {
let eviction_proactive_size_threshold = self.eviction_proactive_size_threshold;

let to_delete: Vec<(u64, u32)> = store
.read_operation_out_of_queue(move |db_ref| {
.read_operation_out_of_queue("do_eviction_by_sampling", move |db_ref| {
let mut pending_volume_remove: u64 = 0;

let now_at_start = Utc::now();
Expand Down Expand Up @@ -1146,6 +1146,7 @@ impl CacheEvictionManager {

let _ = store
.read_operation_out_of_queue_opt(
"check_compaction_trigger",
|db_ref| {
let start: Option<&[u8]> = None;
let end: Option<&[u8]> = None;
Expand Down
6 changes: 3 additions & 3 deletions rust/cubestore/cubestore/src/cachestore/cache_rocksstore.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -876,7 +876,7 @@ pub trait CacheStore: DIService + Send + Sync {
impl CacheStore for RocksCacheStore {
async fn cache_all(&self, limit: Option<usize>) -> Result<Vec<IdRow<CacheItem>>, CubeError> {
self.store
.read_operation_out_of_queue(move |db_ref| {
.read_operation_out_of_queue("cache_all", move |db_ref| {
Ok(CacheItemRocksTable::new(db_ref).scan_rows(limit)?)
})
.await
Expand Down Expand Up @@ -1510,7 +1510,7 @@ impl CacheStore for RocksCacheStore {

async fn compaction(&self) -> Result<(), CubeError> {
self.store
.read_operation_out_of_queue(move |db_ref| {
.read_operation_out_of_queue("compaction", move |db_ref| {
let start: Option<&[u8]> = None;
let end: Option<&[u8]> = None;

Expand All @@ -1525,7 +1525,7 @@ impl CacheStore for RocksCacheStore {

async fn info(&self) -> Result<CachestoreInfo, CubeError> {
self.store
.read_operation_out_of_queue(move |db_ref| {
.read_operation_out_of_queue("info", move |db_ref| {
let cache_schema = CacheItemRocksTable::new(db_ref.clone());
let cache_schema_stats = cache_schema.collect_table_stats_by_extended_index(
&CacheItemRocksIndex::ByPath,
Expand Down
Loading
Loading