Skip to content

Conversation

@ovr
Copy link
Member

@ovr ovr commented Sep 23, 2025

No description provided.

@ovr ovr requested review from a team as code owners September 23, 2025 11:04
@ovr ovr marked this pull request as draft September 23, 2025 11:11
.iter()
.filter(|hint| !hint.is_empty())
.last()
.next_back()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.42%. Comparing base (c217386) to head (9fe14e6).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/pg-srv/src/values/date.rs 0.00% 4 Missing ⚠️
rust/cubesql/cubesql/src/compile/rewrite/mod.rs 50.00% 2 Missing ⚠️
rust/cubesql/pg-srv/src/buffer.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9987      +/-   ##
==========================================
- Coverage   84.67%   83.42%   -1.25%     
==========================================
  Files         254      254              
  Lines       90329    74858   -15471     
==========================================
- Hits        76482    62453   -14029     
+ Misses      13847    12405    -1442     
Flag Coverage Δ
cubesql 83.42% <78.12%> (-1.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

from_sql: bool,
created: DateTime<Utc>,
query: ast::Statement,
query: Box<ast::Statement>,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&meta_context,
alias_to_cube_var,
&[column.clone()],
std::slice::from_ref(column),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ovr ovr marked this pull request as ready for review September 23, 2025 12:17
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@ovr ovr merged commit a94cb60 into master Sep 23, 2025
82 of 85 checks passed
@ovr ovr deleted the feat/rust-1.90.0 branch September 23, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants