Upgrade rust 1.84.1 -> 1.90.0 (stable)

.github/workflows/drivers-tests.yml

@@ -111,7 +111,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.84.1
+          toolchain: 1.90.0
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt

.github/workflows/master.yml

@@ -56,7 +56,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.84.1
+          toolchain: 1.90.0
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt

.github/workflows/post-release.yml

@@ -35,7 +35,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.84.1
+          toolchain: 1.90.0
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt

.github/workflows/publish.yml

@@ -22,7 +22,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.84.1
+          toolchain: 1.90.0
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt
@@ -96,7 +96,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.84.1
+          toolchain: 1.90.0
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt
@@ -186,7 +186,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.84.1
+          toolchain: 1.90.0
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt
@@ -261,7 +261,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.84.1
+          toolchain: 1.90.0
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt

.github/workflows/push.yml

@@ -148,7 +148,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.84.1
+          toolchain: 1.90.0
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt
@@ -213,7 +213,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.84.1
+          toolchain: 1.90.0
           components: rustfmt
       - name: Cargo test cubeorchestrator
         run: cargo test --manifest-path rust/cubeorchestrator/Cargo.toml -j 4
@@ -276,7 +276,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.84.1
+          toolchain: 1.90.0
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt
@@ -424,7 +424,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.84.1
+          toolchain: 1.90.0
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt

.github/workflows/rust-cubesql.yml

@@ -32,7 +32,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.84.1
+          toolchain: 1.90.0
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt, clippy
@@ -149,7 +149,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.84.1
+          toolchain: 1.90.0
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt
@@ -255,7 +255,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.84.1
+          toolchain: 1.90.0
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt
@@ -338,7 +338,7 @@ jobs:
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.84.1
+          toolchain: 1.90.0
           # override: true # this is by default on
           rustflags: ""
           components: rustfmt

packages/cubejs-backend-native/rust-toolchain.toml

@@ -1,4 +1,4 @@
 [toolchain]
-channel = "1.84.1"
+channel = "1.90.0"
 components = ["rustfmt", "clippy"]
 profile = "minimal"

packages/cubejs-backend-native/src/cross/clrepr.rs

@@ -43,7 +43,7 @@ impl CLReprObject {
         self.0.insert(key, value)
     }
 
-    pub fn iter(&self) -> Iter<String, CLRepr> {
+    pub fn iter(&self) -> Iter<'_, String, CLRepr> {
         self.0.iter()
     }
 

packages/cubejs-backend-native/src/orchestrator.rs

@@ -144,7 +144,7 @@ impl ValueObject for ResultWrapper {
         }
     }
 
-    fn get(&mut self, index: usize, field_name: &str) -> Result<FieldValue, CubeError> {
+    fn get(&mut self, index: usize, field_name: &str) -> Result<FieldValue<'_>, CubeError> {
         if self.transformed_data.is_none() {
             self.transform_result()?;
         }

packages/cubejs-backend-native/src/stream.rs

@@ -200,7 +200,7 @@ impl ValueObject for JsValueObject<'_> {
         Ok(self.handle.len(&mut self.cx) as usize)
     }
 
-    fn get(&mut self, index: usize, field_name: &str) -> Result<FieldValue, CubeError> {
+    fn get(&mut self, index: usize, field_name: &str) -> Result<FieldValue<'_>, CubeError> {
         let value = self
             .handle
             .get::<JsObject, _, _>(&mut self.cx, index as u32)

rust/cubenativeutils/rust-toolchain.toml

@@ -1,4 +1,4 @@
 [toolchain]
-channel = "1.84.1"
+channel = "1.90.0"
 components = ["rustfmt", "rustc-dev", "clippy"]
 profile = "minimal"

rust/cubeorchestrator/rust-toolchain.toml

@@ -1,4 +1,4 @@
 [toolchain]
-channel = "1.84.1"
+channel = "1.90.0"
 components = ["rustfmt", "clippy"]
 profile = "minimal"

rust/cubeshared/rust-toolchain.toml

@@ -1,4 +1,4 @@
 [toolchain]
-channel = "1.84.1"
+channel = "1.90.0"
 components = ["rustfmt", "clippy"]
 profile = "minimal"

rust/cubesql/CLAUDE.md

@@ -15,7 +15,7 @@ This is a Rust workspace containing three crates:
 
 ### Prerequisites
 ```bash
-# Install required Rust toolchain (1.84.1)
+# Install required Rust toolchain (1.90.0)
 rustup update
 
 # Install snapshot testing tool

rust/cubesql/cubesql/src/compile/engine/df/scan.rs

@@ -271,8 +271,11 @@ pub enum FieldValue<'a> {
 pub trait ValueObject {
     fn len(&mut self) -> std::result::Result<usize, CubeError>;
 
-    fn get(&mut self, index: usize, field_name: &str)
-        -> std::result::Result<FieldValue, CubeError>;
+    fn get(
+        &mut self,
+        index: usize,
+        field_name: &str,
+    ) -> std::result::Result<FieldValue<'_>, CubeError>;
 }
 
 pub struct JsonValueObject {
@@ -294,7 +297,7 @@ impl ValueObject for JsonValueObject {
         &mut self,
         index: usize,
         field_name: &str,
-    ) -> std::result::Result<FieldValue, CubeError> {
+    ) -> std::result::Result<FieldValue<'_>, CubeError> {
         let Some(as_object) = self.rows[index].as_object() else {
             return Err(CubeError::user(format!(
                 "Unexpected response from Cube, row is not an object: {:?}",

rust/cubesql/cubesql/src/compile/engine/df/wrapper.rs

@@ -44,7 +44,6 @@ use std::{
     convert::TryInto,
     fmt,
     future::Future,
-    iter,
     pin::Pin,
     result,
     sync::{Arc, LazyLock},
@@ -137,17 +136,17 @@ fn extract_group_type_from_groupping_set(
         match expr {
             Expr::GroupingSet(groupping_set) => match groupping_set {
                 GroupingSet::Rollup(exprs) => {
-                    result.extend(
-                        iter::repeat(Some(GroupingSetDesc::new(GroupingSetType::Rollup, id)))
-                            .take(exprs.len()),
-                    );
+                    result.extend(std::iter::repeat_n(
+                        Some(GroupingSetDesc::new(GroupingSetType::Rollup, id)),
+                        exprs.len(),
+                    ));
                     id += 1;
                 }
                 GroupingSet::Cube(exprs) => {
-                    result.extend(
-                        iter::repeat(Some(GroupingSetDesc::new(GroupingSetType::Cube, id)))
-                            .take(exprs.len()),
-                    );
+                    result.extend(std::iter::repeat_n(
+                        Some(GroupingSetDesc::new(GroupingSetType::Cube, id)),
+                        exprs.len(),
+                    ));
                     id += 1;
                 }
                 GroupingSet::GroupingSets(_) => {

rust/cubesql/cubesql/src/compile/rewrite/mod.rs

@@ -1076,7 +1076,7 @@ impl Searcher<LogicalPlanLanguage, LogicalPlanAnalysis> for ListNodeSearcher {
         egraph: &CubeEGraph,
         eclass: Id,
         limit: usize,
-    ) -> Option<SearchMatches<LogicalPlanLanguage>> {
+    ) -> Option<SearchMatches<'_, LogicalPlanLanguage>> {
         let mut matches = SearchMatches {
             substs: vec![],
             eclass,
@@ -1097,7 +1097,7 @@ impl Searcher<LogicalPlanLanguage, LogicalPlanAnalysis> for ListNodeSearcher {
         egraph: &CubeEGraph,
         eclasses: &mut dyn Iterator<Item = Id>,
         limit: usize,
-    ) -> Vec<SearchMatches<LogicalPlanLanguage>> {
+    ) -> Vec<SearchMatches<'_, LogicalPlanLanguage>> {
         let mut result: Vec<SearchMatches<_>> = vec![];
 
         self.list_pattern
@@ -2280,7 +2280,7 @@ impl Searcher<LogicalPlanLanguage, LogicalPlanAnalysis> for ChainSearcher {
         egraph: &CubeEGraph,
         eclasses: &mut dyn Iterator<Item = Id>,
         limit: usize,
-    ) -> Vec<SearchMatches<LogicalPlanLanguage>> {
+    ) -> Vec<SearchMatches<'_, LogicalPlanLanguage>> {
         let matches = self
             .main
             .search_eclasses_with_limit(egraph, eclasses, limit);
@@ -2298,7 +2298,7 @@ impl Searcher<LogicalPlanLanguage, LogicalPlanAnalysis> for ChainSearcher {
         egraph: &CubeEGraph,
         eclass: Id,
         limit: usize,
-    ) -> Option<SearchMatches<LogicalPlanLanguage>> {
+    ) -> Option<SearchMatches<'_, LogicalPlanLanguage>> {
         if let Some(m) = self.main.search_eclass_with_limit(egraph, eclass, limit) {
             self.search_match_chained(egraph, m)
         } else {

rust/cubesql/cubesql/src/compile/rewrite/rewriter.rs

@@ -545,7 +545,7 @@ impl egg::RewriteScheduler<LogicalPlanLanguage, LogicalPlanAnalysis> for Increme
             self.current_eclasses.extend(
                 egraph
                     .classes()
-                    .filter(|class| (class.data.iteration_timestamp >= iteration))
+                    .filter(|class| class.data.iteration_timestamp >= iteration)
                     .map(|class| class.id),
             );
         };

rust/cubesql/cubesql/src/compile/rewrite/rules/filters.rs

@@ -2983,7 +2983,7 @@ impl FilterRules {
                         subst,
                         &meta_context,
                         alias_to_cube_var,
-                        &[column.clone()],
+                        std::slice::from_ref(column),
                         members_var,
                         &aliases,
                     ) else {

rust/cubesql/cubesql/src/compile/rewrite/rules/members.rs

@@ -2708,7 +2708,7 @@ impl MemberRules {
                             let Some(left_cube) = left_join_hints
                                 .iter()
                                 .filter(|hint| !hint.is_empty())
-                                .last()
+                                .next_back()
                                 .and_then(|hint| hint.last())
                                 .or_else(|| left_alias_to_cube.first().map(|(_, cube)| cube))
                                 .cloned()

rust/cubesql/cubesql/src/sql/postgres/extended.rs

@@ -27,17 +27,17 @@ use async_stream::stream;
 
 #[derive(Debug)]
 pub struct Cursor {
-    pub query: ast::Statement,
+    pub query: Box<ast::Statement>,
     // WITH HOLD specifies that the cursor can continue to be used after the transaction that created it successfully commits.
-    // WITHOUT HOLD specifies that the cursor cannot be used outside of the transaction that created it.
+    // WITHOUT HOLD specifies that the cursor cannot be used outside the transaction that created it.
     pub hold: bool,
     // What format will be used for Cursor
     pub format: protocol::Format,
 }
 
 #[derive(Debug)]
 pub enum PreparedStatement {
-    // Postgres allows to define prepared statement on empty query: "",
+    // Postgres allows defining a prepared statement on an empty query: "",
     // then it requires special handling in the protocol
     Empty {
         /// Prepared statement can be declared from SQL or protocol (Parser)
@@ -49,10 +49,10 @@ pub enum PreparedStatement {
         /// Prepared statement can be declared from SQL or protocol (Parser)
         from_sql: bool,
         created: DateTime<Utc>,
-        query: ast::Statement,
+        query: Box<ast::Statement>,
         parameters: protocol::ParameterDescription,
-        /// Fields which will be returned to the client, It can be None if server doesnt return any field
-        /// for example BEGIN
+        /// Fields which will be returned to the client; It can be None if the server doesn't return any field,
+        /// for example, BEGIN
         description: Option<protocol::RowDescription>,
         span_id: Option<Arc<SpanId>>,
     },
@@ -107,7 +107,7 @@ impl PreparedStatement {
             .into()),
             PreparedStatement::Query { query, .. } => {
                 let binder = PostgresStatementParamsBinder::new(values);
-                let mut statement = query.clone();
+                let mut statement = query.as_ref().clone();
                 binder.bind(&mut statement)?;
 
                 Ok(statement)

rust/cubesql/cubesql/src/sql/postgres/shim.rs

@@ -1218,7 +1218,7 @@ impl AsyncPostgresShim {
                             PreparedStatement::Query {
                                 from_sql,
                                 created: chrono::offset::Utc::now(),
-                                query,
+                                query: Box::new(query),
                                 parameters: protocol::ParameterDescription::new(parameters),
                                 description,
                                 span_id,
@@ -1479,7 +1479,7 @@ impl AsyncPostgresShim {
                 })?;
 
                 let plan = convert_statement_to_cube_query(
-                    cursor.query.clone(),
+                    cursor.query.as_ref().clone(),
                     meta,
                     self.session.clone(),
                     qtrace,
@@ -1556,7 +1556,7 @@ impl AsyncPostgresShim {
                 .await?;
 
                 let cursor = Cursor {
-                    query: select_stmt,
+                    query: Box::new(select_stmt),
                     hold: hold.unwrap_or(false),
                     format: if binary { Format::Binary } else { Format::Text },
                 };