Skip to content

fix: Improve error message returned by Subsume #3862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+1,695 −58
Open

fix: Improve error message returned by Subsume #3862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1856281
Add tests for errors generated by subsume
GrahamDennis Mar 29, 2025
d50ef8c
fix: Improve error message returned by Subsume
GrahamDennis Mar 28, 2025
d27ca9c
fix: Remove dead code and respond to feedback.
GrahamDennis Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions internal/core/subsume/subsume.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,9 @@ func (s *subsumer) getError() (err errors.Error) {
if s.gt != nil && s.lt != nil {
// src := binSrc(token.NoPos, opUnify, s.gt, s.lt)
if s.missing != 0 {
s.errf("missing field %q", s.missing.SelectorString(c))
} else if b, ok := unifyValue(c, s.gt, s.lt).(*adt.Bottom); !ok {
s.errf("value not an instance")
s.errf("field %q not present in %v", s.missing.SelectorString(c), s.lt)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit contains rephrasing of error messages, as well as logic changes. This makes it non-trivial to see which tests change because of what. These should be separated out in different CLs.

} else {
s.errs = errors.Append(s.errs, b.Err)
s.errf("%v does not subsume %v", s.gt, s.lt)
}
}
if s.errs == nil {
Expand Down
Loading